perl6-internals
[Top] [All Lists]

Re: [perl #48014] [DEPRECATED] PMC union struct

To: parrotbug-followup@parrotcode.org
Subject: Re: [perl #48014] [DEPRECATED] PMC union struct
From: NotFound <julian.notfound@gmail.com>
Date: Thu, 28 Aug 2008 10:46:42 +0200
Cc: perl6-internals@perl.org
Delivered-to: mailing list perl6-all@perl.org
Delivered-to: perl6-all-poster@perl.org
Delivered-to: mailing list perl6-internals@perl.org
Delivered-to: perl6-internals@perl.org
Delivered-to: parrotbug-followup@parrotcode.org
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to :subject:cc:in-reply-to:mime-version:content-type:references; bh=XymliFI3RZLGxvS8RCigx7zKYqADuLqjMX2IAdzsYZw=; b=oe3dGA9C0kbu9VOwtX0gzj0NAf1u8vMBlCg6bfnADl74rGHXHez7Rpkf9UE2Lm4VXs haYgUf0GDxxhppl8dBcsPn51Hm347UAT4gRRgP8L0N4ywrfThHHJsgHH8MrWYL5sdOO8 fmAP9G012BcKB8REk8OGez5g5KDoY+exv8Cp0=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version :content-type:references; b=b42bSWS+heYqUOw2vvRHMkS1FZhl/UsG6d9lJnHDXmX9P5RRmzaF76+eMVIWAWIvR/ NXU2FN2t79nGPIglgfUNhXRaEOkrxjIkHXlrOfZXxfuobGxy7SHfeBUuD4d6NessE0af vT+Ipepy2Q9surSWdoZeXDlruOTtOeGyylVts=
In-reply-to: <rt-3.6.HEAD-8814-1215995511-380.48014-15-0@perl.org>
List-help: <mailto:perl6-all-help@perl.org>
List-id: <perl6-all.perl.org>
List-id: <perl6-internals.perl.org>
List-post: <mailto:perl6-all@perl.org>
List-subscribe: <mailto:perl6-all-subscribe@perl.org>
List-unsubscribe: <mailto:perl6-all-unsubscribe@perl.org>
Mailing-list: contact perl6-all-help@perl.org; run by ezmlm
References: <RT-Ticket-48014@perl.org> <20071201222135.81260.qmail@spout.spiders.net> <rt-3.6.HEAD-25460-1206504100-1744.48014-15-0@perl.org> <200803252130.15846.chromatic@wgz.org> <rt-3.6.HEAD-25460-1206506070-645.48014-15-0@perl.org> <rt-3.6.HEAD-27577-1215119520-196.48014-15-0@perl.org> <3a6254190807110940k1753c1f0lf4d55f5e6302bb37@mail.gmail.com> <rt-3.6.HEAD-8814-1215794481-559.48014-15-0@perl.org> <rt-3.6.HEAD-8814-1215995511-380.48014-15-0@perl.org>
On Mon, Jul 14, 2008 at 2:31 AM, Allison Randal via RT
<parrotbug-followup@parrotcode.org> wrote:

>> There is a problem with the autogenerated name: in several cases there
>> are other things with that name. For example, for the float.pmc we
>> have the Parrot_Float type defined in include/parrot/config.h
>> Given that the name will be mainly used via macros, a long and
>> meaningful name can be used, such as Parrot_PMCdata_<PMCname>
>
> That's a good refinement, we can make the change after the next release.

The attached patch does it. There is a lot of changes, I suspect many
of them are candidates for replacing with use of the SET_ATTR and
GET_ATTR macros. Maybe defining a macro SELF_DATA_TYPE will be a
convenient shortcut.

I only modified and tested parrot core, surely several languages needs
some patching. Also, don't fixed line length codingstd. I expect
approval before taken care of that,

-- 
Salu2

Attachment: attr_pmc_data.patch
Description: Text Data

<Prev in Thread] Current Thread [Next in Thread>
  • Re: [perl #48014] [DEPRECATED] PMC union struct, NotFound <=