Reini Urban wrote:
> +=head1 DESCRIPTION
> +
> +Parrot installation mechanisms are more powerful than perl5's.
> +MANIFEST contains also the end location, tools/dev/install_files.pl is driven
> +by this definition.
To me it's not clear what the "end location" is - care to elaborate?
Moritz
--
Moritz Lenz
http://moritz.faui2k3.org/ | http://perl-6.de/
From: Allison Randal <allison@perl.org>
X-Virus-Check-By: mailtest2.pair.com
X-Spam-Check-By: mailtest2.pair.com
X-Spam-Status: No, hits=-10.6 required=4.0 tests=BAYES_00,RCVD_IN_DNSWL_HI
autolearn=ham version=3.002004
X-Spam-Flag: NO
X-Spam-Level:
X-Spam-Filtered: 052f96e22adcb440ba93d277d4a1272f
Mailing-List: contact perl6-all-help@perl.org; run by ezmlm
Precedence: bulk
List-Post: <mailto:perl6-all@perl.org>
List-Help: <mailto:perl6-all-help@perl.org>
List-Unsubscribe: <mailto:perl6-all-unsubscribe@perl.org>
List-Subscribe: <mailto:perl6-all-subscribe@perl.org>
List-Id: <perl6-all.perl.org>
Delivered-To: mailing list perl6-all@perl.org
Delivered-To: perl6-all-poster@perl.org
X-Mailing-List: contact perl6-internals-help@perl.org; run by ezmlm
X-Mailing-List-Name: perl6-internals
List-Id: <perl6-internals.perl.org>
Delivered-To: mailing list perl6-internals@perl.org
Delivered-To: perl6-internals@perl.org
Delivered-To: perlmail-parrot-porters@onion.perl.org
Delivered-To: parrot-porters@perl.org
Message-ID: <48B670FE.2010209@perl.org>
Date: Thu, 28 Aug 2008 11:33:50 +0200
User-Agent: Thunderbird 2.0.0.16 (Macintosh/20080707)
MIME-Version: 1.0
To: NotFound <julian.notfound@gmail.com>, p2 <parrot-porters@perl.org>
Subject: Re: struct and pointer to pointer in ATTR
References: <3a6254190808270001w67bad96fpa087ae6d5fee2ac1@mail.gmail.com>
In-Reply-To: <3a6254190808270001w67bad96fpa087ae6d5fee2ac1@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-Old-Spam-Check-By: la.mx.develooper.com
X-Old-Spam-Status: No, hits=-2.6 required=8.0
tests=BAYES_00
X-Old-Spam-Check-By: la.mx.develooper.com
X-Old-Spam-Status: No, hits=-10.6 required=8.0
tests=BAYES_00,RCVD_IN_DNSWL_HI
NotFound wrote:
> Hello.
>
> The current grammar for ATTR in pmc2c allows declarations of the form:
> <type> * varname
>
> In the perl6multisub pmc we have the attribute candidates_sorted whose
> intended type is candidate_info **, having two problems:
>
> The current grammar allows a single pointer, not a pointer to a
> pointer. This can be easily solved.
>
> candidate_info is a struct declared in the pmc file (as typedef struct
> candidate_info { ... } candidate_info), then his declaration is not
> viewable at the point of inclusion of the generated h file. This can
> be solved by declaring the ATTR with type struct candidate_info
> instead of candidate_info, but the grammar for ATTR does not allow it.
>
> I think that allowing struct in ATTR is the simpler solution to the
> second problem, because the intended usage is for struct used
> internally in the pmc, not for his documented interface.
>
> The attached patch changes the ATTR grammar and uses the changes to
> clean the workarounds currently used in perl6multsub pmc. It passes
> all coretest on my system, both building with C or with C++.
Approved for application. But, keep in mind that ATTRs other than
INTVAL, FLOATVAL, STRING *, and PMC * cannot have automatic
GET_ATTR/SET_ATTR accessor macros generated for them, and any C PMCs
with these low-level ATTRs cannot be subclassed from PIR/HLLs.
Allison
|