perl6-internals
[Top] [All Lists]

Re: [PATCH] cygwin070patches_4.patch

To: Reini Urban <rurban@x-ray.at>
Subject: Re: [PATCH] cygwin070patches_4.patch
From: Allison Randal <allison@perl.org>
Date: Thu, 28 Aug 2008 22:42:10 +0200
Cc: p2 <parrot-porters@perl.org>
Delivered-to: mailing list perl6-all@perl.org
Delivered-to: perl6-all-poster@perl.org
Delivered-to: mailing list perl6-internals@perl.org
Delivered-to: perl6-internals@perl.org
Delivered-to: perlmail-parrot-porters@onion.perl.org
Delivered-to: parrot-porters@perl.org
In-reply-to: <48B5931A.5000503@x-ray.at>
List-help: <mailto:perl6-all-help@perl.org>
List-id: <perl6-all.perl.org>
List-id: <perl6-internals.perl.org>
List-post: <mailto:perl6-all@perl.org>
List-subscribe: <mailto:perl6-all-subscribe@perl.org>
List-unsubscribe: <mailto:perl6-all-unsubscribe@perl.org>
Mailing-list: contact perl6-all-help@perl.org; run by ezmlm
References: <48B5931A.5000503@x-ray.at>
User-agent: Thunderbird 2.0.0.16 (Macintosh/20080707)
Reini Urban wrote:
A new idea:
===========
#IF(darwin):
#ALSO:# MACOSX_DEPLOYMENT_TARGET must be defined for OS X
#ALSO:export MACOSX_DEPLOYMENT_TARGET := @osx_version@

Just a little too much complexity, for not enough benefit.

The POD for this change:

Looks good.

For legacy the old syntax #CONDITIONED_LINE(var): and
#INVERSE_CONDITIONED_LINE(var): is also supported.

Mention that this syntax will be deprecated.

For lispers the well-known reader-macro syntax #+(and key1 (not key2)):
is also supported, #+ #- with and, or and not, or being the default
for multiple keys without operator. But note the ending C<:>.

This syntax is not supported. The primary reason for rejecting the syntax is because it's too much of a burden on maintainers. If we keep the feature someone will certainly use it, and some poor P-language programmer is going to get stuck trying to decipher it.

  * or a key=value expression, which checks for the config key,
    Note that values may contain no spaces here. Quotes in values
    are not supported.

Seems like a sensible addition, though very limited. Make it '==' instead of '='.

A key must only consist of word characters, and is checked
case-sensitively against the config key or the platform name.

Explicitly say what you mean by "word characters", because different languages treat different characters as word forming. If you mean A-Z, a-z, and 0-9, say so.

Allison


<Prev in Thread] Current Thread [Next in Thread>