Allison Randal schrieb:
Reini Urban wrote:
A new idea:
===========
#IF(darwin):
#ALSO:# MACOSX_DEPLOYMENT_TARGET must be defined for OS X
#ALSO:export MACOSX_DEPLOYMENT_TARGET := @osx_version@
Just a little too much complexity, for not enough benefit.
The POD for this change:
Looks good.
For legacy the old syntax #CONDITIONED_LINE(var): and
#INVERSE_CONDITIONED_LINE(var): is also supported.
Mention that this syntax will be deprecated.
For lispers the well-known reader-macro syntax #+(and key1 (not key2)):
is also supported, #+ #- with and, or and not, or being the default
for multiple keys without operator. But note the ending C<:>.
This syntax is not supported. The primary reason for rejecting the
syntax is because it's too much of a burden on maintainers. If we keep
the feature someone will certainly use it, and some poor P-language
programmer is going to get stuck trying to decipher it.
I hope you know that this #+() syntax is the only existing syntax.
It is widely used since about 20 years.
The rest is something new we came up with.
I deleted it. Sigh.
* or a key=value expression, which checks for the config key,
Note that values may contain no spaces here. Quotes in values
are not supported.
Seems like a sensible addition, though very limited. Make it '=='
instead of '='.
A key must only consist of word characters, and is checked
case-sensitively against the config key or the platform name.
Explicitly say what you mean by "word characters", because different
languages treat different characters as word forming. If you mean A-Z,
a-z, and 0-9, say so.
Ok, the cygwin070patches_7.patch includes all of these suggestions.
There's still a parser problem with some obscure logic, which I
have to fix. See the TODO tests.
First I want cygwin070patches_6.patch to be applied,
then this patch cygwin070patches_7.patch.
ChangeLog for 7. For 6 see other mail:
applied Allisons suggestions for key==value, doc improvements,
removed lisp-style, more tests, and detected some TODO cases.
--
Reini Urban
http://phpwiki.org/ http://murbreak.at/
cygwin070patches_6.patch.gz
Description: GNU Zip compressed data
cygwin070patches_7.patch.gz
Description: GNU Zip compressed data
|