perl6-internals
[Top] [All Lists]

[perl #58484] Use of uninitialized value in scalar assignment at lib/Par

To: bugs-bitbucket@netlabs.develooper.com
Subject: [perl #58484] Use of uninitialized value in scalar assignment at lib/Parrot/Revision.pm line 95.
From: Ron Schmidt (via RT) <parrotbug-followup@parrotcode.org>
Date: Sun, 31 Aug 2008 14:23:50 -0700
Delivered-to: mailing list perl6-all@perl.org
Delivered-to: perl6-all-poster@perl.org
Delivered-to: mailing list perl6-internals@perl.org
Delivered-to: moderator for perl6-internals@perl.org
Delivered-to: perl6-internals@perl.org
In-reply-to: <48BB0BBD.3030606@software-path.com>
List-help: <mailto:perl6-all-help@perl.org>
List-id: <perl6-all.perl.org>
List-id: <perl6-internals.perl.org>
List-post: <mailto:perl6-all@perl.org>
List-subscribe: <mailto:perl6-all-subscribe@perl.org>
List-unsubscribe: <mailto:perl6-all-unsubscribe@perl.org>
Mail-followup-to: perl6-internals@perl.org
Mailing-list: contact perl6-all-help@perl.org; run by ezmlm
Managed-by: RT 3.6.HEAD (http://www.bestpractical.com/rt/)
References: <RT-Ticket-58484@perl.org> <48BB0BBD.3030606@software-path.com>
Reply-to: perl6-internals@perl.org
Resent-date: Sun, 31 Aug 2008 14:23:51 -0700
Resent-from: rt-ronaldxs=software-path.com@netlabs.develooper.com
Resent-message-id: <200808312123.m7VLNpWk017469@x17.develooper.com>
Resent-to: perl6-internals@perl.org
Rt-originator: ronaldxs@software-path.com
Rt-ticket: perl #58484
# New Ticket Created by  Ron Schmidt 
# Please include the string:  [perl #58484]
# in the subject line of all future correspondence about this issue. 
# <URL: http://rt.perl.org/rt3/Ticket/Display.html?id=58484 >


Warning occurs when issuing 'perl Configure.pl' under cygwin where the
LANG environment variable does not have a default value on my system.
Patch to fix is included below.

Index: lib/Parrot/Revision.pm
===================================================================
--- lib/Parrot/Revision.pm      (revision 30633)
+++ lib/Parrot/Revision.pm      (working copy)
@@ -80,19 +80,18 @@
}

sub _analyze_sandbox {
+    local %ENV = %ENV;
     my $revision = 0;
     # code taken from pugs/util/version_h.pl rev 14410
     # modified because in xml output commit and entry revision
     # are difficult to distinguih in a simplified parsing
     my $nul = File::Spec->devnull;
-    my $oldLANG = $ENV{LANG};
     $ENV{LANG} = 'C';
     if ( my @svn_info = qx/svn info 2>$nul/ and $? == 0 ) {
         if ( my ($line) = grep /^Revision:/, @svn_info ) {
             ($revision) = $line =~ /(\d+)/;
         }
     }
-    $ENV{LANG} = $oldLANG;
     return $revision;
}



<Prev in Thread] Current Thread [Next in Thread>
  • [perl #58484] Use of uninitialized value in scalar assignment at lib/Parrot/Revision.pm line 95., via RT <=